fix(android): clamp text decoration offsets to truncated layout - #58366
Open
lazerg wants to merge 1 commit into
Open
fix(android): clamp text decoration offsets to truncated layout#58366lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
kdwkr
added a commit
to scatterlab/react-native
that referenced
this pull request
Sep 10, 2026
) RNGP 가 `com.facebook.react:react-android:<VERSION_NAME>` 을 Maven Central 에서 force resolve 하고 `VERSION_NAME` 은 업스트림 base 로 고정해야 하므로, fork 의 `ReactAndroid/**` 수정은 소비자 앱에서 컴파일된 적이 없다. 그 경로를 만든다. - `scatterlab-prebuild-android.yml` — `publishAllToMavenTempLocal` 산출물을 `prebuilt-android-<version>` **draft** 릴리스에 올리고 `verify` 통과 후 승격 - `scripts/android/scatterlab-prebuilt-maven.gradle` — 소비자가 받아 sha256 검증·캐시하고 `react.internal.mavenLocalRepo` 로 넘긴다 - `__tests__/android-prebuilt-consumer-test.sh` — fail-closed 동작 스모크, `prepare` 잡에서 매 실행 - 첫 화물: `TextDecorationStyle` IndexOutOfBounds (상류 react#58366 체리픽) 핵심 함정: `VERSION_NAME` 고정 탓에 모든 fork 버전의 AAR 좌표가 동일하다. 소비자 캐시를 fork 버전으로 스코프하고, `verify_symbol` 로 상류 base AAR 대비 새 심볼 존재를 대조해야 "아티팩트가 있다"가 "패치가 들어 있다"를 보증한다. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, a
TextwithnumberOfLinescan crash when a nestedTexthastextDecorationLine: 'underline'or'line-through'and the decorated span starts or ends past what the truncated layout actually rendered.drawSpannedDecoration()readsstart/endfrom the full, untruncatedSpannedtext and passes them straight toLayout.getPrimaryHorizontal(), which throwsIndexOutOfBoundsExceptiononce numberOfLines cuts the layout shorter than the span.This clamps both offsets to the last position the truncated (and possibly tail-ellipsized) layout can actually resolve before using them, so a partially hidden span draws its decoration up to the visible boundary and a fully hidden span draws nothing, instead of crashing.
Changelog:
[ANDROID] [FIXED] - Fix crash drawing text decoration (underline/strikethrough) when a nested Text's span extends past a numberOfLines-truncated layout
Test Plan:
Added two regression tests in
TextDecorationStyleTest: both build a single-line, tail-ellipsizedStaticLayoutand confirm they throwIndexOutOfBoundsExceptionagainst the pre-fix code. With the fix, one asserts the decoration line is drawn clamped to the visible boundary for a span that starts visible and runs past it, and the other asserts a span that starts entirely past the visible boundary draws a zero-length (invisible) line instead of crashing.Fixes #58356